Skip to content

Commit

Permalink
ext4: replace kmem_cache_create with KMEM_CACHE
Browse files Browse the repository at this point in the history
Replace kmem_cache_create with KMEM_CACHE macro that
guaranteed struct alignment

Signed-off-by: JunChao Sun <sunjunchao2870@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221109153822.80250-1-sunjunchao2870@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
  • Loading branch information
JunChao Sun authored and Theodore Ts'o committed Dec 9, 2022
1 parent 89481b5 commit 060f773
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
8 changes: 2 additions & 6 deletions fs/ext4/extents_status.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,7 @@ static void __revise_pending(struct inode *inode, ext4_lblk_t lblk,

int __init ext4_init_es(void)
{
ext4_es_cachep = kmem_cache_create("ext4_extent_status",
sizeof(struct extent_status),
0, (SLAB_RECLAIM_ACCOUNT), NULL);
ext4_es_cachep = KMEM_CACHE(extent_status, SLAB_RECLAIM_ACCOUNT);
if (ext4_es_cachep == NULL)
return -ENOMEM;
return 0;
Expand Down Expand Up @@ -1807,9 +1805,7 @@ static void ext4_print_pending_tree(struct inode *inode)

int __init ext4_init_pending(void)
{
ext4_pending_cachep = kmem_cache_create("ext4_pending_reservation",
sizeof(struct pending_reservation),
0, (SLAB_RECLAIM_ACCOUNT), NULL);
ext4_pending_cachep = KMEM_CACHE(pending_reservation, SLAB_RECLAIM_ACCOUNT);
if (ext4_pending_cachep == NULL)
return -ENOMEM;
return 0;
Expand Down
5 changes: 2 additions & 3 deletions fs/ext4/readpage.c
Original file line number Diff line number Diff line change
Expand Up @@ -410,9 +410,8 @@ int ext4_mpage_readpages(struct inode *inode,

int __init ext4_init_post_read_processing(void)
{
bio_post_read_ctx_cache =
kmem_cache_create("ext4_bio_post_read_ctx",
sizeof(struct bio_post_read_ctx), 0, 0, NULL);
bio_post_read_ctx_cache = KMEM_CACHE(bio_post_read_ctx, SLAB_RECLAIM_ACCOUNT);

if (!bio_post_read_ctx_cache)
goto fail;
bio_post_read_ctx_pool =
Expand Down

0 comments on commit 060f773

Please sign in to comment.