Skip to content

Commit

Permalink
net/mlx5e: Pass actions param to actions_match_supported()
Browse files Browse the repository at this point in the history
Currently the mlx5_flow object contains a single mlx5_attr instance.
However, multi table actions (e.g. CT) instantiate multiple attr instances.

Currently action_match_supported() reads the actions flag from the
flow's attribute instance. Modify the function to receive the action
flags as a parameter which is set by the calling function and
pass the aggregated actions to actions_match_supported().

Signed-off-by: Roi Dayan <roid@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
  • Loading branch information
Roi Dayan authored and Saeed Mahameed committed Feb 17, 2022
1 parent d1a3138 commit 0610f8d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
1 change: 1 addition & 0 deletions drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/act.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ struct mlx5e_tc_act_parse_state {
unsigned int num_actions;
struct mlx5e_tc_flow *flow;
struct netlink_ext_ack *extack;
u32 actions;
bool ct;
bool encap;
bool decap;
Expand Down
10 changes: 7 additions & 3 deletions drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
Original file line number Diff line number Diff line change
Expand Up @@ -3257,11 +3257,11 @@ actions_match_supported_fdb(struct mlx5e_priv *priv,
static bool
actions_match_supported(struct mlx5e_priv *priv,
struct flow_action *flow_action,
u32 actions,
struct mlx5e_tc_flow_parse_attr *parse_attr,
struct mlx5e_tc_flow *flow,
struct netlink_ext_ack *extack)
{
u32 actions = flow->attr->action;
bool ct_flow, ct_clear;

ct_clear = flow->attr->ct_attr.ct_action & TCA_CT_ACT_CLEAR;
Expand Down Expand Up @@ -3344,6 +3344,8 @@ parse_tc_actions(struct mlx5e_tc_act_parse_state *parse_state,
err = tc_act->parse_action(parse_state, act, priv, attr);
if (err)
return err;

parse_state->actions |= attr->action;
}

flow_action_for_each(i, act, flow_action) {
Expand Down Expand Up @@ -3445,7 +3447,8 @@ parse_tc_nic_actions(struct mlx5e_priv *priv,
if (err)
return err;

if (!actions_match_supported(priv, flow_action, parse_attr, flow, extack))
if (!actions_match_supported(priv, flow_action, parse_state->actions,
parse_attr, flow, extack))
return -EOPNOTSUPP;

return 0;
Expand Down Expand Up @@ -3574,7 +3577,8 @@ parse_tc_fdb_actions(struct mlx5e_priv *priv,
if (err)
return err;

if (!actions_match_supported(priv, flow_action, parse_attr, flow, extack))
if (!actions_match_supported(priv, flow_action, parse_state->actions,
parse_attr, flow, extack))
return -EOPNOTSUPP;

return 0;
Expand Down

0 comments on commit 0610f8d

Please sign in to comment.