Skip to content

Commit

Permalink
clk/Renesas-MSTP: Use kmalloc_array() in cpg_mstp_clocks_init()
Browse files Browse the repository at this point in the history
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
  • Loading branch information
Markus Elfring authored and Stephen Boyd committed Sep 16, 2016
1 parent faabbe5 commit 0637a4c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/clk/renesas/clk-mstp.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ static void __init cpg_mstp_clocks_init(struct device_node *np)
unsigned int i;

group = kzalloc(sizeof(*group), GFP_KERNEL);
clks = kmalloc(MSTP_MAX_CLOCKS * sizeof(*clks), GFP_KERNEL);
clks = kmalloc_array(MSTP_MAX_CLOCKS, sizeof(*clks), GFP_KERNEL);
if (group == NULL || clks == NULL) {
kfree(group);
kfree(clks);
Expand Down

0 comments on commit 0637a4c

Please sign in to comment.