Skip to content

Commit

Permalink
drm/i915/dg1: Don't program PHY_MISC for PHY-C and PHY-D
Browse files Browse the repository at this point in the history
The only bit we use in PHY_MISC is DE_IO_COMP_PWR_DOWN, and the bspec
details for that bit tell us that it need only be set for PHY-A and
PHY-B.  It also turns out that there isn't even an instance of the
PHY_MISC register for PHY-D on this platform.  Let's extend the EHL/RKL
logic that conditionally skips PHY_MISC usage to DG1 as well.

Bspec: 50107
Cc: Aditya Swarup <aditya.swarup@intel.com>
Cc: Clinton Taylor <Clinton.A.Taylor@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201007002210.3678024-6-lucas.demarchi@intel.com
  • Loading branch information
Matt Roper authored and Lucas De Marchi committed Oct 7, 2020
1 parent fb7318c commit 0642c2b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/gpu/drm/i915/display/intel_combo_phy.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ static bool has_phy_misc(struct drm_i915_private *i915, enum phy phy)
* other combo PHY's.
*/
if (IS_ELKHARTLAKE(i915) ||
IS_ROCKETLAKE(i915))
IS_ROCKETLAKE(i915) ||
IS_DG1(i915))
return phy < PHY_C;

return true;
Expand Down

0 comments on commit 0642c2b

Please sign in to comment.