Skip to content

Commit

Permalink
drm/modes: Move 3D stereo flag check into drm_mode_validate_basic()
Browse files Browse the repository at this point in the history
Currently we don't sanity check the 3D stereo flags for modes filled out
by the kernel. Move the check from drm_mode_convert_umode() into
drm_mode_validate_basic() so that we get the same check going both ways.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171114183258.16976-2-ville.syrjala@linux.intel.com
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Ville Syrjälä committed Jan 29, 2018
1 parent 2a8d3ea commit 064a3e6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/gpu/drm/drm_modes.c
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,9 @@ EXPORT_SYMBOL(drm_mode_equal_no_clocks_no_stereo);
enum drm_mode_status
drm_mode_validate_basic(const struct drm_display_mode *mode)
{
if ((mode->flags & DRM_MODE_FLAG_3D_MASK) > DRM_MODE_FLAG_3D_MAX)
return MODE_BAD;

if (mode->clock == 0)
return MODE_CLOCK_LOW;

Expand Down Expand Up @@ -1574,9 +1577,6 @@ int drm_mode_convert_umode(struct drm_display_mode *out,
goto out;
}

if ((in->flags & DRM_MODE_FLAG_3D_MASK) > DRM_MODE_FLAG_3D_MAX)
goto out;

out->clock = in->clock;
out->hdisplay = in->hdisplay;
out->hsync_start = in->hsync_start;
Expand Down

0 comments on commit 064a3e6

Please sign in to comment.