Skip to content

Commit

Permalink
fbdev: goldfishfb: Do not check 0 for platform_get_irq()
Browse files Browse the repository at this point in the history
Since platform_get_irq() never returned zero, so it need not to check
whether it returned zero, and we use the return error code of
platform_get_irq() to replace the current return error code.

Please refer to the commit a85a6c8 ("driver core: platform: Clarify
that IRQ 0 is invalid") to get that platform_get_irq() never returned
zero.

Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Signed-off-by: Helge Deller <deller@gmx.de>
  • Loading branch information
Zhu Wang authored and Helge Deller committed Aug 15, 2023
1 parent 73d7f28 commit 0650d50
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/video/fbdev/goldfishfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,8 @@ static int goldfish_fb_probe(struct platform_device *pdev)
}

fb->irq = platform_get_irq(pdev, 0);
if (fb->irq <= 0) {
ret = -ENODEV;
if (fb->irq < 0) {
ret = fb->irq;
goto err_no_irq;
}

Expand Down

0 comments on commit 0650d50

Please sign in to comment.