Skip to content

Commit

Permalink
scsi: lpfc: Remove lpfc_enable_pbde as module parameter
Browse files Browse the repository at this point in the history
Enablement of the PBDE optimization brought out some incompatible behaviors
under error scenarios.

Best to disable and remove the PBDE optimization.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
James Smart authored and Martin K. Petersen committed Aug 2, 2018
1 parent 24bc311 commit 06b6fa3
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions drivers/scsi/lpfc/lpfc_attr.c
Original file line number Diff line number Diff line change
Expand Up @@ -5387,14 +5387,6 @@ LPFC_BBCR_ATTR_RW(enable_bbcr, 1, 0, 1, "Enable BBC Recovery");
*/
LPFC_ATTR_RW(enable_dpp, 1, 0, 1, "Enable Direct Packet Push");

/*
* lpfc_enable_pbde: Enable PBDE on PRISM - G7
* 0 = PBDE on G7 disabled
* 1 = PBDE on G7 enabled (default)
* Value range is [0,1]. Default value is 1
*/
LPFC_ATTR_R(enable_pbde, 1, 0, 1, "Enable PBDE support on PRISM");

struct device_attribute *lpfc_hba_attrs[] = {
&dev_attr_nvme_info,
&dev_attr_bg_info,
Expand Down Expand Up @@ -5506,7 +5498,6 @@ struct device_attribute *lpfc_hba_attrs[] = {
&dev_attr_lpfc_enable_mds_diags,
&dev_attr_lpfc_enable_bbcr,
&dev_attr_lpfc_enable_dpp,
&dev_attr_lpfc_enable_pbde,
NULL,
};

Expand Down Expand Up @@ -6541,7 +6532,6 @@ lpfc_get_cfgparam(struct lpfc_hba *phba)
lpfc_nvme_io_channel_init(phba, lpfc_nvme_io_channel);
lpfc_enable_bbcr_init(phba, lpfc_enable_bbcr);
lpfc_enable_dpp_init(phba, lpfc_enable_dpp);
lpfc_enable_pbde_init(phba, lpfc_enable_pbde);

if (phba->sli_rev != LPFC_SLI_REV4) {
/* NVME only supported on SLI4 */
Expand All @@ -6558,6 +6548,8 @@ lpfc_get_cfgparam(struct lpfc_hba *phba)
phba->cfg_auto_imax = 0;
phba->initial_imax = phba->cfg_fcp_imax;

phba->cfg_enable_pbde = 0;

/* A value of 0 means use the number of CPUs found in the system */
if (phba->cfg_fcp_io_channel == 0)
phba->cfg_fcp_io_channel = phba->sli4_hba.num_present_cpu;
Expand Down

0 comments on commit 06b6fa3

Please sign in to comment.