Skip to content

Commit

Permalink
NFS: fix the return value of nfs_file_fsync()
Browse files Browse the repository at this point in the history
By the commit af7fa16 2010-08-03 NFS: Fix up the fsync code
close(2) became returning the non-zero value even if it went well.
nfs_file_fsync() should return 0 when "status" is positive.

Signed-off-by: J. R. Okajima <hooanon05@yahoo.co.jp>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
J. R. Okajima authored and Trond Myklebust committed Aug 11, 2010
1 parent 15cdc64 commit 0702099
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nfs/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ nfs_file_fsync(struct file *file, int datasync)
have_error |= test_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags);
if (have_error)
ret = xchg(&ctx->error, 0);
if (!ret)
if (!ret && status < 0)
ret = status;
return ret;
}
Expand Down

0 comments on commit 0702099

Please sign in to comment.