Skip to content

Commit

Permalink
mac80211: disallow moving netns
Browse files Browse the repository at this point in the history
mac80211 currently assumes init_net for all interfaces,
so really will not cope well with network namespaces,
at least at this time.

To change this, we would have keep track of the netns
in addition to the ifindex, which is not something I
want to think about right now.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Johannes Berg authored and John W. Linville committed Feb 27, 2009
1 parent 53d6f81 commit 076ae60
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions net/mac80211/iface.c
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,7 @@ int ieee80211_if_add(struct ieee80211_local *local, const char *name,

memcpy(ndev->dev_addr, local->hw.wiphy->perm_addr, ETH_ALEN);
SET_NETDEV_DEV(ndev, wiphy_dev(local->hw.wiphy));
ndev->features |= NETIF_F_NETNS_LOCAL;

/* don't use IEEE80211_DEV_TO_SUB_IF because it checks too much */
sdata = netdev_priv(ndev);
Expand Down
1 change: 1 addition & 0 deletions net/mac80211/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,7 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)

memcpy(local->mdev->dev_addr, local->hw.wiphy->perm_addr, ETH_ALEN);
SET_NETDEV_DEV(local->mdev, wiphy_dev(local->hw.wiphy));
local->mdev->features |= NETIF_F_NETNS_LOCAL;

result = register_netdevice(local->mdev);
if (result < 0)
Expand Down

0 comments on commit 076ae60

Please sign in to comment.