Skip to content

Commit

Permalink
cpuset: remove fast exit path from remove_tasks_in_empty_cpuset()
Browse files Browse the repository at this point in the history
The function isn't that hot, the overhead of missing the fast exit is
low, the test itself depends heavily on cgroup internals, and it's
gonna be a hindrance when trying to decouple cpuset locking from
cgroup core.  Remove the fast exit path.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Li Zefan <lizefan@huawei.com>
  • Loading branch information
Tejun Heo committed Jan 7, 2013
1 parent 01c889c commit 0772324
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions kernel/cpuset.c
Original file line number Diff line number Diff line change
Expand Up @@ -1967,14 +1967,6 @@ static void remove_tasks_in_empty_cpuset(struct cpuset *cs)
{
struct cpuset *parent;

/*
* The cgroup's css_sets list is in use if there are tasks
* in the cpuset; the list is empty if there are none;
* the cs->css.refcnt seems always 0.
*/
if (list_empty(&cs->css.cgroup->css_sets))
return;

/*
* Find its next-highest non-empty parent, (top cpuset
* has online cpus, so can't be empty).
Expand Down

0 comments on commit 0772324

Please sign in to comment.