Skip to content

Commit

Permalink
scsi: smartpqi: Fix ISR accessing uninitialized data
Browse files Browse the repository at this point in the history
Correct driver's ISR accessing a data structure member that has not been
fully initialized during driver initialization.

The pqi queue groups can have uninitialized members when an interrupt
fires. This has not resulted in any driver crashes. This was found during
our own internal testing. No bugs were ever filed.

Link: https://lore.kernel.org/r/20210714182847.50360-9-don.brace@microchip.com
Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Signed-off-by: Mike McGowen <mike.mcgowen@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
Mike McGowen authored and Martin K. Petersen committed Jul 20, 2021
1 parent 09d9968 commit 0777a3f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/scsi/smartpqi/smartpqi_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -7760,11 +7760,11 @@ static int pqi_ctrl_init(struct pqi_ctrl_info *ctrl_info)

pqi_init_operational_queues(ctrl_info);

rc = pqi_request_irqs(ctrl_info);
rc = pqi_create_queues(ctrl_info);
if (rc)
return rc;

rc = pqi_create_queues(ctrl_info);
rc = pqi_request_irqs(ctrl_info);
if (rc)
return rc;

Expand Down

0 comments on commit 0777a3f

Please sign in to comment.