Skip to content

Commit

Permalink
perf util: Rename read_*() functions in trace-event-info.c
Browse files Browse the repository at this point in the history
It's confusing to have same name for two difference functions which does
something opposite way.  Since what they do in this file is read *AND*
writing some of tracing metadata files, rename them to record_*() looks
better to me.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1370323231-14022-15-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Namhyung Kim authored and Arnaldo Carvalho de Melo committed Jul 12, 2013
1 parent 47390ae commit 077f159
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions tools/perf/util/trace-event-info.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ static int record_file(const char *file, ssize_t hdr_sz)
return err;
}

static int read_header_files(void)
static int record_header_files(void)
{
char *path;
struct stat st;
Expand Down Expand Up @@ -240,7 +240,7 @@ static int copy_event_system(const char *sys, struct tracepoint_path *tps)
return err;
}

static int read_ftrace_files(struct tracepoint_path *tps)
static int record_ftrace_files(struct tracepoint_path *tps)
{
char *path;
int ret;
Expand Down Expand Up @@ -269,7 +269,7 @@ static bool system_in_tp_list(char *sys, struct tracepoint_path *tps)
return false;
}

static int read_event_files(struct tracepoint_path *tps)
static int record_event_files(struct tracepoint_path *tps)
{
struct dirent *dent;
struct stat st;
Expand Down Expand Up @@ -344,7 +344,7 @@ static int read_event_files(struct tracepoint_path *tps)
return err;
}

static int read_proc_kallsyms(void)
static int record_proc_kallsyms(void)
{
unsigned int size;
const char *path = "/proc/kallsyms";
Expand All @@ -362,7 +362,7 @@ static int read_proc_kallsyms(void)
return record_file(path, 4);
}

static int read_ftrace_printk(void)
static int record_ftrace_printk(void)
{
unsigned int size;
char *path;
Expand Down Expand Up @@ -539,19 +539,19 @@ struct tracing_data *tracing_data_get(struct list_head *pattrs,
err = tracing_data_header();
if (err)
goto out;
err = read_header_files();
err = record_header_files();
if (err)
goto out;
err = read_ftrace_files(tps);
err = record_ftrace_files(tps);
if (err)
goto out;
err = read_event_files(tps);
err = record_event_files(tps);
if (err)
goto out;
err = read_proc_kallsyms();
err = record_proc_kallsyms();
if (err)
goto out;
err = read_ftrace_printk();
err = record_ftrace_printk();

out:
/*
Expand Down

0 comments on commit 077f159

Please sign in to comment.