Skip to content

Commit

Permalink
drm/file: Uncompact the feature flags
Browse files Browse the repository at this point in the history
This essentially undoes

commit 39868bd
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Oct 29 08:55:58 2013 +0000

    drm: Compact booleans within struct drm_file

We do lockless access to these flags everywhere, and it's kinda not a
great idea to mix lockless and bitfields. Aside from that gcc isn't
generating great code for these.

If this ever becomes an issue size-wise, I think we need atomic_t here
and atomic bitflag ops.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Herrmann <dh.herrmann@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181102132543.16486-2-daniel.vetter@ffwll.ch
  • Loading branch information
Daniel Vetter committed Nov 6, 2018
1 parent a0c1af4 commit 078b7de
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions include/drm/drm_file.h
Original file line number Diff line number Diff line change
Expand Up @@ -164,40 +164,40 @@ struct drm_file {
* See also the :ref:`section on primary nodes and authentication
* <drm_primary_node>`.
*/
unsigned authenticated :1;
bool authenticated;

/**
* @stereo_allowed:
*
* True when the client has asked us to expose stereo 3D mode flags.
*/
unsigned stereo_allowed :1;
bool stereo_allowed;

/**
* @universal_planes:
*
* True if client understands CRTC primary planes and cursor planes
* in the plane list. Automatically set when @atomic is set.
*/
unsigned universal_planes:1;
bool universal_planes;

/** @atomic: True if client understands atomic properties. */
unsigned atomic:1;
bool atomic;

/**
* @aspect_ratio_allowed:
*
* True, if client can handle picture aspect ratios, and has requested
* to pass this information along with the mode.
*/
unsigned aspect_ratio_allowed:1;
bool aspect_ratio_allowed;

/**
* @writeback_connectors:
*
* True if client understands writeback connectors
*/
unsigned writeback_connectors:1;
bool writeback_connectors;

/**
* @is_master:
Expand All @@ -208,7 +208,7 @@ struct drm_file {
* See also the :ref:`section on primary nodes and authentication
* <drm_primary_node>`.
*/
unsigned is_master:1;
bool is_master;

/**
* @master:
Expand Down

0 comments on commit 078b7de

Please sign in to comment.