Skip to content

Commit

Permalink
net/fsl: use of_property_read_bool
Browse files Browse the repository at this point in the history
Use of_property_read_bool to check for the existence of a property.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,x;
@@
-	if (of_get_property(e1,e2,NULL))
-		x = true;
-	else
-		x = false;
+	x = of_property_read_bool(e1,e2);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed Aug 8, 2016
1 parent 7f5d5af commit 07bf2e1
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/net/ethernet/freescale/xgmac_mdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
goto err_ioremap;
}

if (of_get_property(pdev->dev.of_node,
"little-endian", NULL))
priv->is_little_endian = true;
else
priv->is_little_endian = false;
priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
"little-endian");

ret = of_mdiobus_register(bus, np);
if (ret) {
Expand Down

0 comments on commit 07bf2e1

Please sign in to comment.