Skip to content

Commit

Permalink
net: ipa: configure memory regions early
Browse files Browse the repository at this point in the history
IPA-resident memory is one of the most primitive resources that
needs initialization, so call init_mem_config() early in
ipa_config().

This is in preparation for initializing the IPA-resident
microcontroller earlier.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alex Elder authored and David S. Miller committed Jul 26, 2021
1 parent 63961f5 commit 07e1f68
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/net/ipa/ipa_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -468,31 +468,31 @@ static int ipa_config(struct ipa *ipa, const struct ipa_data *data)

ipa_hardware_config(ipa, data);

ret = ipa_endpoint_config(ipa);
ret = ipa_mem_config(ipa);
if (ret)
goto err_hardware_deconfig;

ret = ipa_mem_config(ipa);
ret = ipa_endpoint_config(ipa);
if (ret)
goto err_endpoint_deconfig;
goto err_mem_deconfig;

ipa_table_config(ipa); /* No deconfig required */

/* Assign resource limitation to each group; no deconfig required */
ret = ipa_resource_config(ipa, data->resource_data);
if (ret)
goto err_mem_deconfig;
goto err_endpoint_deconfig;

ret = ipa_modem_config(ipa);
if (ret)
goto err_mem_deconfig;
goto err_endpoint_deconfig;

return 0;

err_mem_deconfig:
ipa_mem_deconfig(ipa);
err_endpoint_deconfig:
ipa_endpoint_deconfig(ipa);
err_mem_deconfig:
ipa_mem_deconfig(ipa);
err_hardware_deconfig:
ipa_hardware_deconfig(ipa);
ipa_clock_put(ipa);
Expand All @@ -507,8 +507,8 @@ static int ipa_config(struct ipa *ipa, const struct ipa_data *data)
static void ipa_deconfig(struct ipa *ipa)
{
ipa_modem_deconfig(ipa);
ipa_mem_deconfig(ipa);
ipa_endpoint_deconfig(ipa);
ipa_mem_deconfig(ipa);
ipa_hardware_deconfig(ipa);
ipa_clock_put(ipa);
}
Expand Down

0 comments on commit 07e1f68

Please sign in to comment.