Skip to content

Commit

Permalink
netlink: specs: rt_addr: fix the spec format / schema failures
Browse files Browse the repository at this point in the history
The spec is mis-formatted, schema validation says:

  Failed validating 'type' in schema['properties']['operations']['properties']['list']['items']['properties']['dump']['properties']['request']['properties']['value']:
    {'minimum': 0, 'type': 'integer'}

  On instance['operations']['list'][3]['dump']['request']['value']:
    '58 - ifa-family'

The ifa-family clearly wants to be part of an attribute list.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Reviewed-by: Yuyang Huang <yuyanghuang@google.com>
Fixes: 4f28037 ("selftests/net: Add selftest for IPv4 RTM_GETMULTICAST support")
Link: https://patch.msgid.link/20250403013706.2828322-2-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Jakub Kicinski committed Apr 4, 2025
1 parent d84366b commit 0802c32
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Documentation/netlink/specs/rt_addr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ operations:
dump:
request:
value: 58
attributes:
- ifa-family
reply:
value: 58
Expand Down

0 comments on commit 0802c32

Please sign in to comment.