Skip to content

Commit

Permalink
GSO/UDP: Use skb->len instead of udph->len to determine length of ori…
Browse files Browse the repository at this point in the history
…ginal skb

It is possible for tunnels to end up generating IP or IPv6 datagrams that
are larger than 64K and expecting to be segmented.  As such we need to deal
with length values greater than 64K.  In order to accommodate this we need
to update the code to work with a 32b length value instead of a 16b one.

Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Duyck authored and David S. Miller committed Mar 14, 2016
1 parent 1e94082 commit 0833482
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions net/ipv4/udp_offload.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,19 @@ static struct sk_buff *__skb_udp_tunnel_segment(struct sk_buff *skb,
__be16 protocol = skb->protocol;
u16 mac_len = skb->mac_len;
int udp_offset, outer_hlen;
u32 partial;
__wsum partial;

if (unlikely(!pskb_may_pull(skb, tnl_hlen)))
goto out;

/* adjust partial header checksum to negate old length */
partial = (__force u32)uh->check + (__force u16)~uh->len;
/* Adjust partial header checksum to negate old length.
* We cannot rely on the value contained in uh->len as it is
* possible that the actual value exceeds the boundaries of the
* 16 bit length field due to the header being added outside of an
* IP or IPv6 frame that was already limited to 64K - 1.
*/
partial = csum_sub(csum_unfold(uh->check),
(__force __wsum)htonl(skb->len));

/* setup inner skb. */
skb->encapsulation = 0;
Expand Down Expand Up @@ -119,8 +125,7 @@ static struct sk_buff *__skb_udp_tunnel_segment(struct sk_buff *skb,
if (!need_csum)
continue;

uh->check = ~csum_fold((__force __wsum)
((__force u32)len + partial));
uh->check = ~csum_fold(csum_add(partial, (__force __wsum)len));

if (skb->encapsulation || !offload_csum) {
uh->check = gso_make_checksum(skb, ~uh->check);
Expand Down

0 comments on commit 0833482

Please sign in to comment.