Skip to content

Commit

Permalink
spi: replace snprintf in show functions with sysfs_emit
Browse files Browse the repository at this point in the history
show() must not use snprintf() when formatting the value to be
returned to user space.

Fix the following coccicheck warning:
drivers/spi/spi-tle62x0.c:144: WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Qing Wang <wangqing@vivo.com>
Link: https://lore.kernel.org/r/1634280668-4954-1-git-send-email-wangqing@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Qing Wang authored and Mark Brown committed Oct 15, 2021
1 parent 2a4a4e8 commit 08411e3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/spi/spi-tle62x0.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ static ssize_t tle62x0_gpio_show(struct device *dev,
value = (st->gpio_state >> gpio_num) & 1;
mutex_unlock(&st->lock);

return snprintf(buf, PAGE_SIZE, "%d", value);
return sysfs_emit(buf, "%d", value);
}

static ssize_t tle62x0_gpio_store(struct device *dev,
Expand Down

0 comments on commit 08411e3

Please sign in to comment.