Skip to content

Commit

Permalink
net: dsa: microchip: ksz8: Unify variable naming in ksz8_r_dyn_mac_ta…
Browse files Browse the repository at this point in the history
…ble()

Use 'ret' instead of 'rc' in ksz8_r_dyn_mac_table() to maintain
consistency with the rest of the file.

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20240403125039.3414824-6-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Oleksij Rempel authored and Jakub Kicinski committed Apr 5, 2024
1 parent 5f1b7f8 commit 08736e0
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/net/dsa/microchip/ksz8795.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ static int ksz8_r_dyn_mac_table(struct ksz_device *dev, u16 addr, u8 *mac_addr,
u64 buf = 0;
u8 data;
int cnt;
int rc;
int ret;

shifts = dev->info->shifts;
masks = dev->info->masks;
Expand All @@ -430,12 +430,12 @@ static int ksz8_r_dyn_mac_table(struct ksz_device *dev, u16 addr, u8 *mac_addr,
mutex_lock(&dev->alu_mutex);
ksz_write16(dev, regs[REG_IND_CTRL_0], ctrl_addr);

rc = ksz8_valid_dyn_entry(dev, &data);
if (rc == -EAGAIN) {
ret = ksz8_valid_dyn_entry(dev, &data);
if (ret == -EAGAIN) {
if (addr == 0)
*entries = 0;
goto unlock_alu;
} else if (rc == -ENXIO) {
} else if (ret == -ENXIO) {
*entries = 0;
goto unlock_alu;
}
Expand Down Expand Up @@ -463,12 +463,12 @@ static int ksz8_r_dyn_mac_table(struct ksz_device *dev, u16 addr, u8 *mac_addr,

mac_addr[1] = (u8)data_hi;
mac_addr[0] = (u8)(data_hi >> 8);
rc = 0;
ret = 0;

unlock_alu:
mutex_unlock(&dev->alu_mutex);

return rc;
return ret;
}

static int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr,
Expand Down

0 comments on commit 08736e0

Please sign in to comment.