Skip to content

Commit

Permalink
hwrng: xgene - fix handling platform_get_irq
Browse files Browse the repository at this point in the history
The function can return negative value.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Andrzej Hajda authored and Herbert Xu committed Sep 21, 2015
1 parent 17762c5 commit 09185e2
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/char/hw_random/xgene-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -344,11 +344,12 @@ static int xgene_rng_probe(struct platform_device *pdev)
if (IS_ERR(ctx->csr_base))
return PTR_ERR(ctx->csr_base);

ctx->irq = platform_get_irq(pdev, 0);
if (ctx->irq < 0) {
rc = platform_get_irq(pdev, 0);
if (rc < 0) {
dev_err(&pdev->dev, "No IRQ resource\n");
return ctx->irq;
return rc;
}
ctx->irq = rc;

dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d",
ctx->csr_base, ctx->irq);
Expand Down

0 comments on commit 09185e2

Please sign in to comment.