Skip to content

Commit

Permalink
uwb: Re-use DEFINE_SHOW_ATTRIBUTE() macro
Browse files Browse the repository at this point in the history
...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Andy Shevchenko authored and Greg Kroah-Hartman committed Mar 9, 2018
1 parent 9e902c5 commit 092bd5c
Showing 1 changed file with 4 additions and 28 deletions.
32 changes: 4 additions & 28 deletions drivers/uwb/uwb-debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ static const struct file_operations command_fops = {
.owner = THIS_MODULE,
};

static int reservations_print(struct seq_file *s, void *p)
static int reservations_show(struct seq_file *s, void *p)
{
struct uwb_rc *rc = s->private;
struct uwb_rsv *rsv;
Expand Down Expand Up @@ -240,21 +240,9 @@ static int reservations_print(struct seq_file *s, void *p)

return 0;
}
DEFINE_SHOW_ATTRIBUTE(reservations);

static int reservations_open(struct inode *inode, struct file *file)
{
return single_open(file, reservations_print, inode->i_private);
}

static const struct file_operations reservations_fops = {
.open = reservations_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
.owner = THIS_MODULE,
};

static int drp_avail_print(struct seq_file *s, void *p)
static int drp_avail_show(struct seq_file *s, void *p)
{
struct uwb_rc *rc = s->private;

Expand All @@ -264,19 +252,7 @@ static int drp_avail_print(struct seq_file *s, void *p)

return 0;
}

static int drp_avail_open(struct inode *inode, struct file *file)
{
return single_open(file, drp_avail_print, inode->i_private);
}

static const struct file_operations drp_avail_fops = {
.open = drp_avail_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
.owner = THIS_MODULE,
};
DEFINE_SHOW_ATTRIBUTE(drp_avail);

static void uwb_dbg_channel_changed(struct uwb_pal *pal, int channel)
{
Expand Down

0 comments on commit 092bd5c

Please sign in to comment.