Skip to content

Commit

Permalink
nilfs2: use list_splice_tail or list_splice_tail_init
Browse files Browse the repository at this point in the history
This applies list_splice_tail (or list_splice_tail_init) operation
instead of list_splice (or list_splice_init, respectively) to append a
new list to tail of an existing list.

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
  • Loading branch information
Ryusuke Konishi committed Nov 28, 2009
1 parent abdb318 commit 0935db7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion fs/nilfs2/btree.c
Original file line number Diff line number Diff line change
Expand Up @@ -2018,7 +2018,7 @@ static void nilfs_btree_lookup_dirty_buffers(struct nilfs_bmap *bmap,
for (level = NILFS_BTREE_LEVEL_NODE_MIN;
level < NILFS_BTREE_LEVEL_MAX;
level++)
list_splice(&lists[level], listp->prev);
list_splice_tail(&lists[level], listp);
}

static int nilfs_btree_assign_p(struct nilfs_btree *btree,
Expand Down
2 changes: 1 addition & 1 deletion fs/nilfs2/recovery.c
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,7 @@ int nilfs_search_super_root(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi,

super_root_found:
/* Updating pointers relating to the latest checkpoint */
list_splice(&segments, ri->ri_used_segments.prev);
list_splice_tail(&segments, &ri->ri_used_segments);
nilfs->ns_last_pseg = sr_pseg_start;
nilfs->ns_last_seq = nilfs->ns_seg_seq;
nilfs->ns_last_cno = ri->ri_cno;
Expand Down
4 changes: 2 additions & 2 deletions fs/nilfs2/segment.c
Original file line number Diff line number Diff line change
Expand Up @@ -1363,7 +1363,7 @@ static int nilfs_segctor_extend_segments(struct nilfs_sc_info *sci,
list_add_tail(&segbuf->sb_list, &list);
prev = segbuf;
}
list_splice(&list, sci->sc_segbufs.prev);
list_splice_tail(&list, &sci->sc_segbufs);
return 0;

failed_segbuf:
Expand Down Expand Up @@ -2532,7 +2532,7 @@ int nilfs_clean_segments(struct super_block *sb, struct nilfs_argv *argv,

sci->sc_freesegs = kbufs[4];
sci->sc_nfreesegs = argv[4].v_nmembs;
list_splice_init(&nilfs->ns_gc_inodes, sci->sc_gc_inodes.prev);
list_splice_tail_init(&nilfs->ns_gc_inodes, &sci->sc_gc_inodes);

for (;;) {
nilfs_segctor_accept(sci, &req);
Expand Down

0 comments on commit 0935db7

Please sign in to comment.