Skip to content

Commit

Permalink
dmaengine: uniphier-xdmac: Remove redandant error log for platform_ge…
Browse files Browse the repository at this point in the history
…t_irq

platform_get_irq prints the error on failure, so there is no need to
have caller add a log.
Remove the log in uniphier_xdmac_probe() for platform_get_irq() failure

Reported-by: kbuild test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/20200323171928.424223-1-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Vinod Koul committed Mar 26, 2020
1 parent 6697255 commit 0950c7f
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/dma/uniphier-xdmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -525,10 +525,8 @@ static int uniphier_xdmac_probe(struct platform_device *pdev)
uniphier_xdmac_chan_init(xdev, i);

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(dev, "Failed to get IRQ\n");
if (irq < 0)
return irq;
}

ret = devm_request_irq(dev, irq, uniphier_xdmac_irq_handler,
IRQF_SHARED, "xdmac", xdev);
Expand Down

0 comments on commit 0950c7f

Please sign in to comment.