Skip to content

Commit

Permalink
lib/crc-t10dif: add support for arch overrides
Browse files Browse the repository at this point in the history
Following what was done for CRC32, add support for architecture-specific
override of the CRC-T10DIF library.  This will allow the CRC-T10DIF
library functions to access architecture-optimized code directly.

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20241202012056.209768-3-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
  • Loading branch information
Eric Biggers committed Dec 2, 2024
1 parent be3c45b commit 0961c3b
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 0 deletions.
12 changes: 12 additions & 0 deletions include/linux/crc-t10dif.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@
#define CRC_T10DIF_DIGEST_SIZE 2
#define CRC_T10DIF_BLOCK_SIZE 1

u16 crc_t10dif_arch(u16 crc, const u8 *p, size_t len);
u16 crc_t10dif_generic(u16 crc, const u8 *p, size_t len);

static inline u16 crc_t10dif_update(u16 crc, const u8 *p, size_t len)
{
if (IS_ENABLED(CONFIG_CRC_T10DIF_ARCH))
return crc_t10dif_arch(crc, p, len);
return crc_t10dif_generic(crc, p, len);
}

Expand All @@ -19,4 +22,13 @@ static inline u16 crc_t10dif(const u8 *p, size_t len)
return crc_t10dif_update(0, p, len);
}

#if IS_ENABLED(CONFIG_CRC_T10DIF_ARCH)
bool crc_t10dif_is_optimized(void);
#else
static inline bool crc_t10dif_is_optimized(void)
{
return false;
}
#endif

#endif
32 changes: 32 additions & 0 deletions lib/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,38 @@ config CRC_T10DIF
kernel tree needs to calculate CRC checks for use with the
SCSI data integrity subsystem.

config ARCH_HAS_CRC_T10DIF
bool

choice
prompt "CRC-T10DIF implementation"
depends on CRC_T10DIF
default CRC_T10DIF_IMPL_ARCH if ARCH_HAS_CRC_T10DIF
default CRC_T10DIF_IMPL_GENERIC if !ARCH_HAS_CRC_T10DIF
help
This option allows you to override the default choice of CRC-T10DIF
implementation.

config CRC_T10DIF_IMPL_ARCH
bool "Architecture-optimized" if ARCH_HAS_CRC_T10DIF
help
Use the optimized implementation of CRC-T10DIF for the selected
architecture. It is recommended to keep this enabled, as it can
greatly improve CRC-T10DIF performance.

config CRC_T10DIF_IMPL_GENERIC
bool "Generic implementation"
help
Use the generic table-based implementation of CRC-T10DIF. Selecting
this will reduce code size slightly but can greatly reduce CRC-T10DIF
performance.

endchoice

config CRC_T10DIF_ARCH
tristate
default CRC_T10DIF if CRC_T10DIF_IMPL_ARCH

config CRC64_ROCKSOFT
tristate "CRC calculation for the Rocksoft model CRC64"
select CRC64
Expand Down

0 comments on commit 0961c3b

Please sign in to comment.