Skip to content

Commit

Permalink
kconfig: make defconfig is no longer chatty
Browse files Browse the repository at this point in the history
make defconfig generated a lot of output
then noone actually read.
Use conf_set_all_new_symbols() to generate the default
configuration and avoid the chatty output.

A typical run now looks like this:
$ make  defconfig
*** Default configuration is based on 'i386_defconfig'
arch/x86/configs/i386_defconfig:13:warning: trying to assign nonexistent symbol SEMAPHORE_SLEEPERS
arch/x86/configs/i386_defconfig:176:warning: trying to assign nonexistent symbol PREEMPT_BKL
...
arch/x86/configs/i386_defconfig:1386:warning: trying to assign nonexistent symbol INSTRUMENTATION
$

As an added benefit we now clearly see the warnings generated
in the start of the process.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
  • Loading branch information
Sam Ravnborg committed Jul 25, 2008
1 parent cd9140e commit 09748e1
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions scripts/kconfig/conf.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,6 @@ static int conf_askvalue(struct symbol *sym, const char *def)
fflush(stdout);
fgets(line, 128, stdin);
return 1;
case set_default:
printf("%s\n", def);
return 1;
default:
break;
}
Expand Down Expand Up @@ -318,10 +315,6 @@ static int conf_choice(struct menu *menu)
else
continue;
break;
case set_default:
cnt = def;
printf("%d\n", cnt);
break;
default:
break;
}
Expand Down Expand Up @@ -589,13 +582,15 @@ int main(int ac, char **av)
case set_random:
conf_set_all_new_symbols(def_random);
break;
case set_default:
conf_set_all_new_symbols(def_default);
break;
case ask_silent:
case ask_new:
if (conf_silent_update())
exit(1);
break;
case ask_all:
case set_default:
if (conf_update())
exit(1);
break;
Expand Down

0 comments on commit 09748e1

Please sign in to comment.