Skip to content

Commit

Permalink
regulator: tps65090: Fix using wrong dev argument for calling of_regu…
Browse files Browse the repository at this point in the history
…lator_match

The dev parameter is the device requesting the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.

The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Axel Lin authored and Mark Brown committed Jan 31, 2013
1 parent 6c7a7a0 commit 09a228e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/regulator/tps65090-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ static struct tps65090_platform_data *tps65090_parse_dt_reg_data(
return ERR_PTR(-ENODEV);
}

ret = of_regulator_match(pdev->dev.parent, regulators, tps65090_matches,
ret = of_regulator_match(&pdev->dev, regulators, tps65090_matches,
ARRAY_SIZE(tps65090_matches));
if (ret < 0) {
dev_err(&pdev->dev,
Expand Down

0 comments on commit 09a228e

Please sign in to comment.