Skip to content

Commit

Permalink
drm/i915: remove duplicate typedef for intel_wakeref_t
Browse files Browse the repository at this point in the history
Fix the duplicate typedef for intel_wakeref_t leading to Clang build
issues. While at it, actually make the intel_runtime_pm.h header
self-contained, which was claimed in the commit being fixed.

Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
References: http://mid.mail-archive.com/20190521183850.GA9157@archlinux-epyc
References: https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/201754420#L2435
Fixes: 0d5adc5 ("drm/i915: extract intel_runtime_pm.h from intel_drv.h")
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190522103505.2082-1-jani.nikula@intel.com
  • Loading branch information
Jani Nikula committed May 23, 2019
1 parent cfc0e7b commit 09a93ef
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions drivers/gpu/drm/i915/Makefile.header-test
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ header_test := \
intel_pm.h \
intel_psr.h \
intel_quirks.h \
intel_runtime_pm.h \
intel_sdvo.h \
intel_sideband.h \
intel_sprite.h \
Expand Down
8 changes: 5 additions & 3 deletions drivers/gpu/drm/i915/intel_runtime_pm.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@
#ifndef __INTEL_RUNTIME_PM_H__
#define __INTEL_RUNTIME_PM_H__

#include <linux/stackdepot.h>
#include <linux/types.h>

struct drm_i915_private;
#include "intel_display.h"
#include "intel_wakeref.h"

typedef depot_stack_handle_t intel_wakeref_t;
struct drm_i915_private;
struct drm_printer;
struct intel_encoder;

enum i915_drm_suspend_mode {
I915_DRM_SUSPEND_IDLE,
Expand Down

0 comments on commit 09a93ef

Please sign in to comment.