Skip to content

Commit

Permalink
bcache: Don't reinvent the wheel but use existing llist API
Browse files Browse the repository at this point in the history
Although llist provides proper APIs, they are not used. Make them used.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Acked-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Byungchul Park authored and Jens Axboe committed Sep 6, 2017
1 parent 69daf03 commit 09b3efe
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions drivers/md/bcache/closure.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,21 +70,10 @@ void __closure_wake_up(struct closure_waitlist *wait_list)
list = llist_del_all(&wait_list->list);

/* We first reverse the list to preserve FIFO ordering and fairness */

while (list) {
struct llist_node *t = list;
list = llist_next(list);

t->next = reverse;
reverse = t;
}
reverse = llist_reverse_order(list);

/* Then do the wakeups */

while (reverse) {
cl = container_of(reverse, struct closure, list);
reverse = llist_next(reverse);

llist_for_each_entry(cl, reverse, list) {
closure_set_waiting(cl, 0);
closure_sub(cl, CLOSURE_WAITING + 1);
}
Expand Down

0 comments on commit 09b3efe

Please sign in to comment.