Skip to content

Commit

Permalink
drm/i915: don't suspend gt until after we disable irqs and display (v2)
Browse files Browse the repository at this point in the history
When I moved the irq disable down to after display disable,
I didn't realise the gt suspend also required irqs off, so move it
down as well.

Fixes WARNs seen at suspend/resume time.

v2: moved the rps flush down as well.

Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
  • Loading branch information
Dave Airlie committed Jul 24, 2014
1 parent 78660d5 commit 09b6426
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/gpu/drm/i915/i915_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -516,11 +516,6 @@ static int i915_drm_freeze(struct drm_device *dev)
return error;
}

flush_delayed_work(&dev_priv->rps.delayed_resume_work);


intel_suspend_gt_powersave(dev);

/*
* Disable CRTCs directly since we want to preserve sw state
* for _thaw.
Expand All @@ -532,8 +527,13 @@ static int i915_drm_freeze(struct drm_device *dev)
drm_modeset_unlock_all(dev);

intel_dp_mst_suspend(dev);

flush_delayed_work(&dev_priv->rps.delayed_resume_work);

intel_runtime_pm_disable_interrupts(dev);

intel_suspend_gt_powersave(dev);

intel_modeset_suspend_hw(dev);
}

Expand Down

0 comments on commit 09b6426

Please sign in to comment.