Skip to content

Commit

Permalink
[PATCH] no need for noinline stuff in fs/namespace.c anymore
Browse files Browse the repository at this point in the history
Stack footprint from hell had been due to many struct nameidata in there.
No more.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Oct 23, 2008
1 parent 2d92ab3 commit 0a0d8a4
Showing 1 changed file with 5 additions and 12 deletions.
17 changes: 5 additions & 12 deletions fs/namespace.c
Original file line number Diff line number Diff line change
Expand Up @@ -1425,9 +1425,8 @@ static int graft_tree(struct vfsmount *mnt, struct path *path)

/*
* recursively change the type of the mountpoint.
* noinline this do_mount helper to save do_mount stack space.
*/
static noinline int do_change_type(struct path *path, int flag)
static int do_change_type(struct path *path, int flag)
{
struct vfsmount *m, *mnt = path->mnt;
int recurse = flag & MS_REC;
Expand Down Expand Up @@ -1459,9 +1458,8 @@ static noinline int do_change_type(struct path *path, int flag)

/*
* do loopback mount.
* noinline this do_mount helper to save do_mount stack space.
*/
static noinline int do_loopback(struct path *path, char *old_name,
static int do_loopback(struct path *path, char *old_name,
int recurse)
{
struct path old_path;
Expand Down Expand Up @@ -1528,9 +1526,8 @@ static int change_mount_flags(struct vfsmount *mnt, int ms_flags)
* change filesystem flags. dir should be a physical root of filesystem.
* If you've mounted a non-root directory somewhere and want to do remount
* on it - tough luck.
* noinline this do_mount helper to save do_mount stack space.
*/
static noinline int do_remount(struct path *path, int flags, int mnt_flags,
static int do_remount(struct path *path, int flags, int mnt_flags,
void *data)
{
int err;
Expand Down Expand Up @@ -1568,10 +1565,7 @@ static inline int tree_contains_unbindable(struct vfsmount *mnt)
return 0;
}

/*
* noinline this do_mount helper to save do_mount stack space.
*/
static noinline int do_move_mount(struct path *path, char *old_name)
static int do_move_mount(struct path *path, char *old_name)
{
struct path old_path, parent_path;
struct vfsmount *p;
Expand Down Expand Up @@ -1648,9 +1642,8 @@ static noinline int do_move_mount(struct path *path, char *old_name)
/*
* create a new mount for userspace and request it to be added into the
* namespace's tree
* noinline this do_mount helper to save do_mount stack space.
*/
static noinline int do_new_mount(struct path *path, char *type, int flags,
static int do_new_mount(struct path *path, char *type, int flags,
int mnt_flags, char *name, void *data)
{
struct vfsmount *mnt;
Expand Down

0 comments on commit 0a0d8a4

Please sign in to comment.