Skip to content

Commit

Permalink
ide-cd: convert to blk_delay_queue() for a short pause
Browse files Browse the repository at this point in the history
It was always abuse to reuse the plugging infrastructure for this,
convert it to the (new) real API for delaying queueing a bit.

Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Acked-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jens Axboe committed Mar 10, 2011
1 parent 3cca6dc commit 0a41e90
Showing 1 changed file with 2 additions and 11 deletions.
13 changes: 2 additions & 11 deletions drivers/ide/ide-cd.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,17 +258,10 @@ static int ide_cd_breathe(ide_drive_t *drive, struct request *rq)
if (time_after(jiffies, info->write_timeout))
return 0;
else {
struct request_queue *q = drive->queue;
unsigned long flags;

/*
* take a breather relying on the unplug timer to kick us again
* take a breather
*/

spin_lock_irqsave(q->queue_lock, flags);
blk_plug_device(q);
spin_unlock_irqrestore(q->queue_lock, flags);

blk_delay_queue(drive->queue, 1);
return 1;
}
}
Expand Down Expand Up @@ -1514,8 +1507,6 @@ static int ide_cdrom_setup(ide_drive_t *drive)
blk_queue_dma_alignment(q, 31);
blk_queue_update_dma_pad(q, 15);

q->unplug_delay = max((1 * HZ) / 1000, 1);

drive->dev_flags |= IDE_DFLAG_MEDIA_CHANGED;
drive->atapi_flags = IDE_AFLAG_NO_EJECT | ide_cd_flags(id);

Expand Down

0 comments on commit 0a41e90

Please sign in to comment.