Skip to content

Commit

Permalink
dm thin: return -ENOSPC when erroring retry list due to out of data s…
Browse files Browse the repository at this point in the history
…pace

Otherwise -EIO would be returned when -ENOSPC should be used
consistently.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
  • Loading branch information
Mike Snitzer committed Jul 26, 2015
1 parent cbfe8fa commit 0a927c2
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions drivers/md/dm-thin.c
Original file line number Diff line number Diff line change
Expand Up @@ -666,16 +666,21 @@ static void requeue_io(struct thin_c *tc)
requeue_deferred_cells(tc);
}

static void error_retry_list(struct pool *pool)
static void error_retry_list_with_code(struct pool *pool, int error)
{
struct thin_c *tc;

rcu_read_lock();
list_for_each_entry_rcu(tc, &pool->active_thins, list)
error_thin_bio_list(tc, &tc->retry_on_resume_list, -EIO);
error_thin_bio_list(tc, &tc->retry_on_resume_list, error);
rcu_read_unlock();
}

static void error_retry_list(struct pool *pool)
{
return error_retry_list_with_code(pool, -EIO);
}

/*
* This section of code contains the logic for processing a thin device's IO.
* Much of the code depends on pool object resources (lists, workqueues, etc)
Expand Down Expand Up @@ -2297,7 +2302,7 @@ static void do_no_space_timeout(struct work_struct *ws)
if (get_pool_mode(pool) == PM_OUT_OF_DATA_SPACE && !pool->pf.error_if_no_space) {
pool->pf.error_if_no_space = true;
notify_of_pool_mode_change_to_oods(pool);
error_retry_list(pool);
error_retry_list_with_code(pool, -ENOSPC);
}
}

Expand Down

0 comments on commit 0a927c2

Please sign in to comment.