Skip to content

Commit

Permalink
nfp: rename ring allocation helpers
Browse files Browse the repository at this point in the history
"Shadow" in ring helpers used to mean that the helper will allocate
rings without touching existing configuration, this was used for
reconfiguration while the device was running.  We will soon use
the same helpers for .ndo_open() path, so replace "shadow" with
"ring_set".

No functional changes.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jakub Kicinski authored and David S. Miller committed Nov 4, 2016
1 parent 68453c7 commit 0ae42df
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions drivers/net/ethernet/netronome/nfp/nfp_net_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -1573,7 +1573,7 @@ static int nfp_net_tx_ring_alloc(struct nfp_net_tx_ring *tx_ring, u32 cnt)
}

static struct nfp_net_tx_ring *
nfp_net_shadow_tx_rings_prepare(struct nfp_net *nn, struct nfp_net_ring_set *s)
nfp_net_tx_ring_set_prepare(struct nfp_net *nn, struct nfp_net_ring_set *s)
{
struct nfp_net_tx_ring *rings;
unsigned int r;
Expand All @@ -1599,7 +1599,7 @@ nfp_net_shadow_tx_rings_prepare(struct nfp_net *nn, struct nfp_net_ring_set *s)
}

static void
nfp_net_shadow_tx_rings_swap(struct nfp_net *nn, struct nfp_net_ring_set *s)
nfp_net_tx_ring_set_swap(struct nfp_net *nn, struct nfp_net_ring_set *s)
{
struct nfp_net_tx_ring *rings = s->rings;
struct nfp_net_ring_set new = *s;
Expand All @@ -1616,7 +1616,7 @@ nfp_net_shadow_tx_rings_swap(struct nfp_net *nn, struct nfp_net_ring_set *s)
}

static void
nfp_net_shadow_tx_rings_free(struct nfp_net *nn, struct nfp_net_ring_set *s)
nfp_net_tx_ring_set_free(struct nfp_net *nn, struct nfp_net_ring_set *s)
{
struct nfp_net_tx_ring *rings = s->rings;
unsigned int r;
Expand Down Expand Up @@ -1693,7 +1693,7 @@ nfp_net_rx_ring_alloc(struct nfp_net_rx_ring *rx_ring, unsigned int fl_bufsz,
}

static struct nfp_net_rx_ring *
nfp_net_shadow_rx_rings_prepare(struct nfp_net *nn, struct nfp_net_ring_set *s)
nfp_net_rx_ring_set_prepare(struct nfp_net *nn, struct nfp_net_ring_set *s)
{
unsigned int fl_bufsz = nfp_net_calc_fl_bufsz(nn, s->mtu);
struct nfp_net_rx_ring *rings;
Expand Down Expand Up @@ -1726,7 +1726,7 @@ nfp_net_shadow_rx_rings_prepare(struct nfp_net *nn, struct nfp_net_ring_set *s)
}

static void
nfp_net_shadow_rx_rings_swap(struct nfp_net *nn, struct nfp_net_ring_set *s)
nfp_net_rx_ring_set_swap(struct nfp_net *nn, struct nfp_net_ring_set *s)
{
struct nfp_net_rx_ring *rings = s->rings;
struct nfp_net_ring_set new = *s;
Expand All @@ -1746,7 +1746,7 @@ nfp_net_shadow_rx_rings_swap(struct nfp_net *nn, struct nfp_net_ring_set *s)
}

static void
nfp_net_shadow_rx_rings_free(struct nfp_net *nn, struct nfp_net_ring_set *s)
nfp_net_rx_ring_set_free(struct nfp_net *nn, struct nfp_net_ring_set *s)
{
struct nfp_net_rx_ring *rings = s->rings;
unsigned int r;
Expand Down Expand Up @@ -2268,9 +2268,9 @@ nfp_net_ring_swap_enable(struct nfp_net *nn,
struct nfp_net_ring_set *tx)
{
if (rx)
nfp_net_shadow_rx_rings_swap(nn, rx);
nfp_net_rx_ring_set_swap(nn, rx);
if (tx)
nfp_net_shadow_tx_rings_swap(nn, tx);
nfp_net_tx_ring_set_swap(nn, tx);

return __nfp_net_set_config_and_enable(nn);
}
Expand Down Expand Up @@ -2299,11 +2299,11 @@ nfp_net_ring_reconfig(struct nfp_net *nn, struct nfp_net_ring_set *rx,

/* Prepare new rings */
if (rx) {
if (!nfp_net_shadow_rx_rings_prepare(nn, rx))
if (!nfp_net_rx_ring_set_prepare(nn, rx))
return -ENOMEM;
}
if (tx) {
if (!nfp_net_shadow_tx_rings_prepare(nn, tx)) {
if (!nfp_net_tx_ring_set_prepare(nn, tx)) {
err = -ENOMEM;
goto err_free_rx;
}
Expand All @@ -2327,17 +2327,17 @@ nfp_net_ring_reconfig(struct nfp_net *nn, struct nfp_net_ring_set *rx,
}

if (rx)
nfp_net_shadow_rx_rings_free(nn, rx);
nfp_net_rx_ring_set_free(nn, rx);
if (tx)
nfp_net_shadow_tx_rings_free(nn, tx);
nfp_net_tx_ring_set_free(nn, tx);

nfp_net_open_stack(nn);

return err;

err_free_rx:
if (rx)
nfp_net_shadow_rx_rings_free(nn, rx);
nfp_net_rx_ring_set_free(nn, rx);
return err;
}

Expand Down

0 comments on commit 0ae42df

Please sign in to comment.