Skip to content

Commit

Permalink
sky2: Receive Overflows not counted
Browse files Browse the repository at this point in the history
[ Upstream commit 9cfe8b1 ]

The sky2 driver doesn't count the Receive Overflows because the MAC
interrupt for this event is not set in the MAC's interrupt mask.
The MAC's interrupt mask is set only for Transmit FIFO Underruns.

Fix: The correct setting should be (GM_IS_TX_FF_UR | GM_IS_RX_FF_OR)
Otherwise the Receive Overflow event will not generate any interrupt.
The  Receive Overflow interrupt is handled correctly

Signed-off-by: Mirko Lindner <mlindner@marvell.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Mirko Lindner authored and Greg Kroah-Hartman committed Apr 5, 2013
1 parent 396db58 commit 0b1a48c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/sky2.h
Original file line number Diff line number Diff line change
Expand Up @@ -2064,7 +2064,7 @@ enum {
GM_IS_RX_FF_OR = 1<<1, /* Receive FIFO Overrun */
GM_IS_RX_COMPL = 1<<0, /* Frame Reception Complete */

#define GMAC_DEF_MSK GM_IS_TX_FF_UR
#define GMAC_DEF_MSK (GM_IS_TX_FF_UR | GM_IS_RX_FF_OR)
};

/* GMAC_LINK_CTRL 16 bit GMAC Link Control Reg (YUKON only) */
Expand Down

0 comments on commit 0b1a48c

Please sign in to comment.