Skip to content

Commit

Permalink
blk-throttle: return proper bool type to caller instead of 0/1
Browse files Browse the repository at this point in the history
Change to return true/false only for bool type return code.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Chengguang Xu authored and Jens Axboe committed May 30, 2018
1 parent d250bf4 commit 0b6bad7
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions block/blk-throttle.c
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ static bool throtl_slice_used(struct throtl_grp *tg, bool rw)
if (time_in_range(jiffies, tg->slice_start[rw], tg->slice_end[rw]))
return false;

return 1;
return true;
}

/* Trim the used slices and adjust slice start accordingly */
Expand Down Expand Up @@ -929,7 +929,7 @@ static bool tg_with_in_iops_limit(struct throtl_grp *tg, struct bio *bio,

if (wait)
*wait = jiffy_wait;
return 0;
return false;
}

static bool tg_with_in_bps_limit(struct throtl_grp *tg, struct bio *bio,
Expand Down Expand Up @@ -972,7 +972,7 @@ static bool tg_with_in_bps_limit(struct throtl_grp *tg, struct bio *bio,
jiffy_wait = jiffy_wait + (jiffy_elapsed_rnd - jiffy_elapsed);
if (wait)
*wait = jiffy_wait;
return 0;
return false;
}

/*
Expand Down Expand Up @@ -1022,7 +1022,7 @@ static bool tg_may_dispatch(struct throtl_grp *tg, struct bio *bio,
tg_with_in_iops_limit(tg, bio, &iops_wait)) {
if (wait)
*wait = 0;
return 1;
return true;
}

max_wait = max(bps_wait, iops_wait);
Expand All @@ -1033,7 +1033,7 @@ static bool tg_may_dispatch(struct throtl_grp *tg, struct bio *bio,
if (time_before(tg->slice_end[rw], jiffies + max_wait))
throtl_extend_slice(tg, rw, jiffies + max_wait);

return 0;
return false;
}

static void throtl_charge_bio(struct throtl_grp *tg, struct bio *bio)
Expand Down

0 comments on commit 0b6bad7

Please sign in to comment.