Skip to content

Commit

Permalink
ASoC: Intel: atom: Check drv->lock is locked in sst_fill_and_send_cmd…
Browse files Browse the repository at this point in the history
…_unlocked

sst_fill_and_send_cmd_unlocked must be called with the drv->lock mutex
locked already. In the past there have been cases where this was not the
case, add a WARN_ON to check for drv->lock being locked.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200402185359.3424-2-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Hans de Goede authored and Mark Brown committed Apr 3, 2020
1 parent 81630dc commit 0bb2be2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions sound/soc/intel/atom/sst-atom-controls.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ static int sst_fill_and_send_cmd_unlocked(struct sst_data *drv,
{
int ret = 0;

WARN_ON(!mutex_is_locked(&drv->lock));

ret = sst_fill_byte_control(drv, ipc_msg,
block, task_id, pipe_id, len, cmd_data);
if (ret < 0)
Expand Down

0 comments on commit 0bb2be2

Please sign in to comment.