Skip to content

Commit

Permalink
x86/microcode: Remove unnecessary perf callback
Browse files Browse the repository at this point in the history
c93dc84 ("perf/x86: Add a microcode revision check for SNB-PEBS")
checks whether the microcode revision has fixed PEBS issues.

This can happen either:

1. At PEBS init time, where the early microcode has been loaded already

2. During late loading, in the microcode_check() callback.

So remove the unnecessary call in the microcode loader init routine.

Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20220525161232.14924-5-bp@alien8.de
  • Loading branch information
Borislav Petkov authored and Thomas Gleixner committed May 31, 2022
1 parent d23d33e commit 0c0fe08
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions arch/x86/kernel/cpu/microcode/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -756,10 +756,7 @@ static int __init microcode_init(void)

cpus_read_lock();
mutex_lock(&microcode_mutex);

error = subsys_interface_register(&mc_cpu_interface);
if (!error)
perf_check_microcode();
mutex_unlock(&microcode_mutex);
cpus_read_unlock();

Expand Down

0 comments on commit 0c0fe08

Please sign in to comment.