Skip to content

Commit

Permalink
r8169: move napi_disable call and rename rtl8169_hw_reset
Browse files Browse the repository at this point in the history
rtl8169_hw_reset() meanwhile does more than a hw reset, therefore rename
it to rtl8169_cleanup(). In addition move calling napi_disable() to this
function.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Heiner Kallweit authored and David S. Miller committed Jun 19, 2020
1 parent 7190aee commit 0c28a63
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/net/ethernet/realtek/r8169_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -3926,8 +3926,10 @@ static void rtl8169_tx_clear(struct rtl8169_private *tp)
netdev_reset_queue(tp->dev);
}

static void rtl8169_hw_reset(struct rtl8169_private *tp, bool going_down)
static void rtl8169_cleanup(struct rtl8169_private *tp, bool going_down)
{
napi_disable(&tp->napi);

/* Give a racing hard_start_xmit a few cycles to complete. */
synchronize_net();

Expand Down Expand Up @@ -3970,10 +3972,9 @@ static void rtl_reset_work(struct rtl8169_private *tp)
struct net_device *dev = tp->dev;
int i;

napi_disable(&tp->napi);
netif_stop_queue(dev);

rtl8169_hw_reset(tp, false);
rtl8169_cleanup(tp, false);

for (i = 0; i < NUM_RX_DESC; i++)
rtl8169_mark_to_asic(tp->RxDescArray + i);
Expand Down Expand Up @@ -4636,9 +4637,8 @@ static void rtl8169_down(struct rtl8169_private *tp)
bitmap_zero(tp->wk.flags, RTL_FLAG_MAX);

phy_stop(tp->phydev);
napi_disable(&tp->napi);

rtl8169_hw_reset(tp, true);
rtl8169_cleanup(tp, true);

rtl_pll_power_down(tp);

Expand Down

0 comments on commit 0c28a63

Please sign in to comment.