Skip to content

Commit

Permalink
xfs: tiny xfs_setattr_mode cleanup
Browse files Browse the repository at this point in the history
Remove the pointless tp argument, and properly align the local variable
declarations.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
  • Loading branch information
Christoph Hellwig authored and Ben Myers committed Dec 6, 2013
1 parent 37eb970 commit 0c3d88d
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions fs/xfs/xfs_iops.c
Original file line number Diff line number Diff line change
Expand Up @@ -459,14 +459,12 @@ xfs_vn_getattr(

static void
xfs_setattr_mode(
struct xfs_trans *tp,
struct xfs_inode *ip,
struct iattr *iattr)
{
struct inode *inode = VFS_I(ip);
umode_t mode = iattr->ia_mode;
struct inode *inode = VFS_I(ip);
umode_t mode = iattr->ia_mode;

ASSERT(tp);
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));

ip->i_d.di_mode &= S_IFMT;
Expand Down Expand Up @@ -633,7 +631,7 @@ xfs_setattr_nonsize(
* Change file access modes.
*/
if (mask & ATTR_MODE)
xfs_setattr_mode(tp, ip, iattr);
xfs_setattr_mode(ip, iattr);

/*
* Change file access or modified times.
Expand Down Expand Up @@ -871,7 +869,7 @@ xfs_setattr_size(
* Change file access modes.
*/
if (mask & ATTR_MODE)
xfs_setattr_mode(tp, ip, iattr);
xfs_setattr_mode(ip, iattr);

if (mask & ATTR_CTIME) {
inode->i_ctime = iattr->ia_ctime;
Expand Down

0 comments on commit 0c3d88d

Please sign in to comment.