Skip to content

Commit

Permalink
pinctrl: bcm: Constify static pinmux_ops
Browse files Browse the repository at this point in the history
These are only assigned, either directly or via the bcm63xx_pinctrl_soc
struct, to the pmxops field in the pinctrl_desc struct and never
modified, so make them const to allow the compiler to put them in
read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20210605185908.39982-3-rikard.falkeborn@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Rikard Falkeborn authored and Linus Walleij committed Jun 9, 2021
1 parent d977909 commit 0c68387
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion drivers/pinctrl/bcm/pinctrl-bcm6318.c
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ static const struct pinctrl_ops bcm6318_pctl_ops = {
.get_groups_count = bcm6318_pinctrl_get_group_count,
};

static struct pinmux_ops bcm6318_pmx_ops = {
static const struct pinmux_ops bcm6318_pmx_ops = {
.get_function_groups = bcm6318_pinctrl_get_groups,
.get_function_name = bcm6318_pinctrl_get_func_name,
.get_functions_count = bcm6318_pinctrl_get_func_count,
Expand Down
2 changes: 1 addition & 1 deletion drivers/pinctrl/bcm/pinctrl-bcm63268.c
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ static const struct pinctrl_ops bcm63268_pctl_ops = {
.get_groups_count = bcm63268_pinctrl_get_group_count,
};

static struct pinmux_ops bcm63268_pmx_ops = {
static const struct pinmux_ops bcm63268_pmx_ops = {
.get_function_groups = bcm63268_pinctrl_get_groups,
.get_function_name = bcm63268_pinctrl_get_func_name,
.get_functions_count = bcm63268_pinctrl_get_func_count,
Expand Down
2 changes: 1 addition & 1 deletion drivers/pinctrl/bcm/pinctrl-bcm6328.c
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ static const struct pinctrl_ops bcm6328_pctl_ops = {
.get_groups_count = bcm6328_pinctrl_get_group_count,
};

static struct pinmux_ops bcm6328_pmx_ops = {
static const struct pinmux_ops bcm6328_pmx_ops = {
.get_function_groups = bcm6328_pinctrl_get_groups,
.get_function_name = bcm6328_pinctrl_get_func_name,
.get_functions_count = bcm6328_pinctrl_get_func_count,
Expand Down
2 changes: 1 addition & 1 deletion drivers/pinctrl/bcm/pinctrl-bcm6358.c
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ static const struct pinctrl_ops bcm6358_pctl_ops = {
.get_groups_count = bcm6358_pinctrl_get_group_count,
};

static struct pinmux_ops bcm6358_pmx_ops = {
static const struct pinmux_ops bcm6358_pmx_ops = {
.get_function_groups = bcm6358_pinctrl_get_groups,
.get_function_name = bcm6358_pinctrl_get_func_name,
.get_functions_count = bcm6358_pinctrl_get_func_count,
Expand Down
2 changes: 1 addition & 1 deletion drivers/pinctrl/bcm/pinctrl-bcm6362.c
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ static const struct pinctrl_ops bcm6362_pctl_ops = {
.get_groups_count = bcm6362_pinctrl_get_group_count,
};

static struct pinmux_ops bcm6362_pmx_ops = {
static const struct pinmux_ops bcm6362_pmx_ops = {
.get_function_groups = bcm6362_pinctrl_get_groups,
.get_function_name = bcm6362_pinctrl_get_func_name,
.get_functions_count = bcm6362_pinctrl_get_func_count,
Expand Down
2 changes: 1 addition & 1 deletion drivers/pinctrl/bcm/pinctrl-bcm6368.c
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ static const struct pinctrl_ops bcm6368_pctl_ops = {
.get_groups_count = bcm6368_pinctrl_get_group_count,
};

static struct pinmux_ops bcm6368_pmx_ops = {
static const struct pinmux_ops bcm6368_pmx_ops = {
.get_function_groups = bcm6368_pinctrl_get_groups,
.get_function_name = bcm6368_pinctrl_get_func_name,
.get_functions_count = bcm6368_pinctrl_get_func_count,
Expand Down
2 changes: 1 addition & 1 deletion drivers/pinctrl/bcm/pinctrl-bcm63xx.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

struct bcm63xx_pinctrl_soc {
const struct pinctrl_ops *pctl_ops;
struct pinmux_ops *pmx_ops;
const struct pinmux_ops *pmx_ops;

const struct pinctrl_pin_desc *pins;
unsigned npins;
Expand Down

0 comments on commit 0c68387

Please sign in to comment.