Skip to content

Commit

Permalink
dm snapshot: remove unnecessary NULL checks before vfree() calls
Browse files Browse the repository at this point in the history
The vfree() function performs input parameter validation.
Thus the NULL pointer test around vfree() calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
  • Loading branch information
Markus Elfring authored and Mike Snitzer committed Feb 9, 2015
1 parent ff658e9 commit 0c8f863
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions drivers/md/dm-snap-persistent.c
Original file line number Diff line number Diff line change
Expand Up @@ -200,16 +200,11 @@ static int alloc_area(struct pstore *ps)

static void free_area(struct pstore *ps)
{
if (ps->area)
vfree(ps->area);
vfree(ps->area);
ps->area = NULL;

if (ps->zero_area)
vfree(ps->zero_area);
vfree(ps->zero_area);
ps->zero_area = NULL;

if (ps->header_area)
vfree(ps->header_area);
vfree(ps->header_area);
ps->header_area = NULL;
}

Expand Down Expand Up @@ -605,8 +600,7 @@ static void persistent_dtr(struct dm_exception_store *store)
free_area(ps);

/* Allocated in persistent_read_metadata */
if (ps->callbacks)
vfree(ps->callbacks);
vfree(ps->callbacks);

kfree(ps);
}
Expand Down

0 comments on commit 0c8f863

Please sign in to comment.