Skip to content

Commit

Permalink
ARM: SAMSUNG: use spin_lock_irqsave() in clk_{enable,disable}
Browse files Browse the repository at this point in the history
The clk_enable()and clk_disable() can be used process and ISR either.
And actually it is used for real product and other platforms use it
now. So spin_lock_irqsave() should be used instead.

Signed-off-by: Minho Ban <mhban@samsung.com>
Signed-off-by: Jaecheol Lee <jc.lee@samsung.com>
Signed-off-by: Sunyoung Kang <sy0816.kang@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
  • Loading branch information
Minho Ban authored and Kukjin Kim committed Feb 11, 2012
1 parent 8942ad8 commit 0cdf3af
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions arch/arm/plat-samsung/clock.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,31 +84,35 @@ static int clk_null_enable(struct clk *clk, int enable)

int clk_enable(struct clk *clk)
{
unsigned long flags;

if (IS_ERR(clk) || clk == NULL)
return -EINVAL;

clk_enable(clk->parent);

spin_lock(&clocks_lock);
spin_lock_irqsave(&clocks_lock, flags);

if ((clk->usage++) == 0)
(clk->enable)(clk, 1);

spin_unlock(&clocks_lock);
spin_unlock_irqrestore(&clocks_lock, flags);
return 0;
}

void clk_disable(struct clk *clk)
{
unsigned long flags;

if (IS_ERR(clk) || clk == NULL)
return;

spin_lock(&clocks_lock);
spin_lock_irqsave(&clocks_lock, flags);

if ((--clk->usage) == 0)
(clk->enable)(clk, 0);

spin_unlock(&clocks_lock);
spin_unlock_irqrestore(&clocks_lock, flags);
clk_disable(clk->parent);
}

Expand Down

0 comments on commit 0cdf3af

Please sign in to comment.