Skip to content

Commit

Permalink
ice: Fix a 32bit bug
Browse files Browse the repository at this point in the history
BIT() is unsigned long but ->pu.flg_msk and ->pu.flg_val are u64 type.
On 32 bit systems, unsigned long is a u32 and the mismatch between u32
and u64 will break things for the high 32 bits.

Fixes: 9a4c07a ("ice: add parser execution main loop")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Link: https://patch.msgid.link/ddc231a8-89c1-4ff4-8704-9198bcb41f8d@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Dan Carpenter authored and Jakub Kicinski committed Aug 22, 2024
1 parent d35a3a8 commit 0ce054f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/ethernet/intel/ice/ice_parser_rt.c
Original file line number Diff line number Diff line change
Expand Up @@ -377,11 +377,11 @@ static void ice_pg_exe(struct ice_parser_rt *rt)

static void ice_flg_add(struct ice_parser_rt *rt, int idx, bool val)
{
rt->pu.flg_msk |= BIT(idx);
rt->pu.flg_msk |= BIT_ULL(idx);
if (val)
rt->pu.flg_val |= BIT(idx);
rt->pu.flg_val |= BIT_ULL(idx);
else
rt->pu.flg_val &= ~BIT(idx);
rt->pu.flg_val &= ~BIT_ULL(idx);

ice_debug(rt->psr->hw, ICE_DBG_PARSER, "Pending update for flag %d value %d\n",
idx, val);
Expand Down

0 comments on commit 0ce054f

Please sign in to comment.