Skip to content

Commit

Permalink
clk: ls1028a: Fix warning on clamp() usage
Browse files Browse the repository at this point in the history
These constants are used in clamp() with the value being clamped an
unsigned long. Make them unsigned long defines so that clamp() doesn't
complain about comparing different types.

In file included from include/linux/list.h:9,
                 from include/linux/kobject.h:19,
                 from include/linux/of.h:17,
                 from include/linux/clk-provider.h:9,
                 from drivers/clk/clk-plldig.c:8:
drivers/clk/clk-plldig.c: In function 'plldig_determine_rate':
include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast
  835 |   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
      |

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Wen He <wen.he_1@nxp.com>
Fixes: d37010a ("clk: ls1028a: Add clock driver for Display output interface")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lkml.kernel.org/r/20200203052507.93215-1-sboyd@kernel.org
  • Loading branch information
Stephen Boyd committed Feb 3, 2020
1 parent db865ee commit 0d152f2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/clk/clk-plldig.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
#define PLLDIG_MAX_VCO_FREQ 1300000000

/* Range of the output frequencies, in Hz */
#define PHI1_MIN_FREQ 27000000
#define PHI1_MAX_FREQ 600000000
#define PHI1_MIN_FREQ 27000000UL
#define PHI1_MAX_FREQ 600000000UL

/* Maximum value of the reduced frequency divider */
#define MAX_RFDPHI1 63UL
Expand Down

0 comments on commit 0d152f2

Please sign in to comment.