Skip to content

Commit

Permalink
slcan: fix ldisc->open retval
Browse files Browse the repository at this point in the history
TTY layer expects 0 if the ldisc->open operation succeeded.

Reported-by: Matvejchikov Ilya <matvejchikov@gmail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Oliver Hartkopp authored and David S. Miller committed May 10, 2011
1 parent aae1e74 commit 0d4420a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/net/can/slcan.c
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,9 @@ static int slcan_open(struct tty_struct *tty)
/* Done. We have linked the TTY line to a channel. */
rtnl_unlock();
tty->receive_room = 65536; /* We don't flow control */
return sl->dev->base_addr;

/* TTY layer expects 0 on success */
return 0;

err_free_chan:
sl->tty = NULL;
Expand Down

0 comments on commit 0d4420a

Please sign in to comment.