Skip to content

Commit

Permalink
drm/i915/adl_p: Same slices mask is not same Dbuf state
Browse files Browse the repository at this point in the history
We currently treat same slice mask as a same DBuf state and skip
updating the Dbuf slices, if we detect that.
This is wrong as if we have a multi to single pipe change or
vice versa, that would be treated as a same Dbuf state and thus
no changes required, so we don't get Mbus updated, causing issues.
Solution: check also mbus_join, in addition to slices mask.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210527110106.21434-1-stanislav.lisovskiy@intel.com
  • Loading branch information
Stanislav Lisovskiy authored and Jani Nikula committed Jun 9, 2021
1 parent d62686b commit 0d6695b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/gpu/drm/i915/intel_pm.c
Original file line number Diff line number Diff line change
@@ -8093,7 +8093,8 @@ void intel_dbuf_pre_plane_update(struct intel_atomic_state *state)
intel_atomic_get_old_dbuf_state(state);

if (!new_dbuf_state ||
new_dbuf_state->enabled_slices == old_dbuf_state->enabled_slices)
((new_dbuf_state->enabled_slices == old_dbuf_state->enabled_slices)
&& (new_dbuf_state->joined_mbus == old_dbuf_state->joined_mbus)))
return;

WARN_ON(!new_dbuf_state->base.changed);
@@ -8113,7 +8114,8 @@ void intel_dbuf_post_plane_update(struct intel_atomic_state *state)
intel_atomic_get_old_dbuf_state(state);

if (!new_dbuf_state ||
new_dbuf_state->enabled_slices == old_dbuf_state->enabled_slices)
((new_dbuf_state->enabled_slices == old_dbuf_state->enabled_slices)
&& (new_dbuf_state->joined_mbus == old_dbuf_state->joined_mbus)))
return;

WARN_ON(!new_dbuf_state->base.changed);

0 comments on commit 0d6695b

Please sign in to comment.