Skip to content

Commit

Permalink
net: renesas: rswitch: Add host_interfaces setting
Browse files Browse the repository at this point in the history
Set phydev->host_interfaces before calling of_phy_connect() to
configure the PHY with the information of host_interfaces.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yoshihiro Shimoda authored and David S. Miller committed Feb 3, 2023
1 parent c16a503 commit 0df024d
Showing 1 changed file with 15 additions and 3 deletions.
18 changes: 15 additions & 3 deletions drivers/net/ethernet/renesas/rswitch.c
Original file line number Diff line number Diff line change
Expand Up @@ -1178,6 +1178,7 @@ static int rswitch_phy_device_init(struct rswitch_device *rdev)
{
struct phy_device *phydev;
struct device_node *phy;
int err = -ENOENT;

if (!rdev->np_port)
return -ENODEV;
Expand All @@ -1186,11 +1187,18 @@ static int rswitch_phy_device_init(struct rswitch_device *rdev)
if (!phy)
return -ENODEV;

/* Set phydev->host_interfaces before calling of_phy_connect() to
* configure the PHY with the information of host_interfaces.
*/
phydev = of_phy_find_device(phy);
if (!phydev)
goto out;
__set_bit(rdev->etha->phy_interface, phydev->host_interfaces);

phydev = of_phy_connect(rdev->ndev, phy, rswitch_adjust_link, 0,
rdev->etha->phy_interface);
of_node_put(phy);
if (!phydev)
return -ENOENT;
goto out;

phy_set_max_speed(phydev, SPEED_2500);
phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_10baseT_Half_BIT);
Expand All @@ -1201,7 +1209,11 @@ static int rswitch_phy_device_init(struct rswitch_device *rdev)

phy_attached_info(phydev);

return 0;
err = 0;
out:
of_node_put(phy);

return err;
}

static void rswitch_phy_device_deinit(struct rswitch_device *rdev)
Expand Down

0 comments on commit 0df024d

Please sign in to comment.