Skip to content

Commit

Permalink
drm/sun4i: rgb: Remove the bridge enable/disable functions
Browse files Browse the repository at this point in the history
The atomic helpers already call the drm_bridge_enable on our behalf,
there's no need to do it a second time.

Reported-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
  • Loading branch information
Maxime Ripard committed Oct 16, 2016
1 parent 5647b25 commit 0df03b4
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/gpu/drm/sun4i/sun4i_rgb.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,6 @@ static void sun4i_rgb_encoder_enable(struct drm_encoder *encoder)
if (!IS_ERR(tcon->panel))
drm_panel_prepare(tcon->panel);

/* encoder->bridge can be NULL; drm_bridge_enable checks for it */
drm_bridge_enable(encoder->bridge);

sun4i_tcon_channel_enable(tcon, 0);

if (!IS_ERR(tcon->panel))
Expand All @@ -177,9 +174,6 @@ static void sun4i_rgb_encoder_disable(struct drm_encoder *encoder)

sun4i_tcon_channel_disable(tcon, 0);

/* encoder->bridge can be NULL; drm_bridge_disable checks for it */
drm_bridge_disable(encoder->bridge);

if (!IS_ERR(tcon->panel))
drm_panel_unprepare(tcon->panel);
}
Expand Down

0 comments on commit 0df03b4

Please sign in to comment.