Skip to content

Commit

Permalink
skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid confli…
Browse files Browse the repository at this point in the history
…cts with leds namespace

Adding led support for phy causes namespace conflicts for some
phy drivers.

The marvel skge driver declared an enum for representing the states of
Link LED Register. The enum contained constant LED_OFF which conflicted
with declartation found in linux/leds.h.
LED_OFF changed to LED_REG_OFF
Also changed LED_ON to LED_REG_ON to avoid possible future conflict and
for consistency.

Signed-off-by: Zach Brown <zach.brown@ni.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Zach Brown authored and David S. Miller committed Oct 18, 2016
1 parent 5bb61cb commit 0e0f27d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions drivers/net/ethernet/marvell/skge.c
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,7 @@ static const char *skge_pause(enum pause_status status)
static void skge_link_up(struct skge_port *skge)
{
skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG),
LED_BLK_OFF|LED_SYNC_OFF|LED_ON);
LED_BLK_OFF|LED_SYNC_OFF|LED_REG_ON);

netif_carrier_on(skge->netdev);
netif_wake_queue(skge->netdev);
Expand All @@ -1062,7 +1062,7 @@ static void skge_link_up(struct skge_port *skge)

static void skge_link_down(struct skge_port *skge)
{
skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_OFF);
skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_REG_OFF);
netif_carrier_off(skge->netdev);
netif_stop_queue(skge->netdev);

Expand Down Expand Up @@ -2668,7 +2668,7 @@ static int skge_down(struct net_device *dev)
if (hw->ports == 1)
free_irq(hw->pdev->irq, hw);

skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_OFF);
skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_REG_OFF);
if (is_genesis(hw))
genesis_stop(skge);
else
Expand Down
4 changes: 2 additions & 2 deletions drivers/net/ethernet/marvell/skge.h
Original file line number Diff line number Diff line change
Expand Up @@ -662,8 +662,8 @@ enum {
LED_BLK_OFF = 1<<4, /* Link LED Blinking Off */
LED_SYNC_ON = 1<<3, /* Use Sync Wire to switch LED */
LED_SYNC_OFF = 1<<2, /* Disable Sync Wire Input */
LED_ON = 1<<1, /* switch LED on */
LED_OFF = 1<<0, /* switch LED off */
LED_REG_ON = 1<<1, /* switch LED on */
LED_REG_OFF = 1<<0, /* switch LED off */
};

/* Receive GMAC FIFO (YUKON) */
Expand Down

0 comments on commit 0e0f27d

Please sign in to comment.