Skip to content

Commit

Permalink
drivers/IB,hfi1: do not se mmap_sem
Browse files Browse the repository at this point in the history
This driver already uses gup_fast() and thus we can just drop the mmap_sem
protection around the pinned_vm counter. Note that the window between when
hfi1_can_pin_pages() is called and the actual counter is incremented
remains the same as mmap_sem was _only_ used for when ->pinned_vm was
touched.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Davidlohr Bueso <dbueso@suse.det>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
  • Loading branch information
Davidlohr Bueso authored and Jason Gunthorpe committed Feb 7, 2019
1 parent 3a2a1e9 commit 0e15c25
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/infiniband/hw/hfi1/user_pages.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,7 @@ bool hfi1_can_pin_pages(struct hfi1_devdata *dd, struct mm_struct *mm,
/* Convert to number of pages */
size = DIV_ROUND_UP(size, PAGE_SIZE);

down_read(&mm->mmap_sem);
pinned = atomic64_read(&mm->pinned_vm);
up_read(&mm->mmap_sem);

/* First, check the absolute limit against all pinned pages. */
if (pinned + npages >= ulimit && !can_lock)
Expand All @@ -111,9 +109,7 @@ int hfi1_acquire_user_pages(struct mm_struct *mm, unsigned long vaddr, size_t np
if (ret < 0)
return ret;

down_write(&mm->mmap_sem);
atomic64_add(ret, &mm->pinned_vm);
up_write(&mm->mmap_sem);

return ret;
}
Expand All @@ -130,8 +126,6 @@ void hfi1_release_user_pages(struct mm_struct *mm, struct page **p,
}

if (mm) { /* during close after signal, mm can be NULL */
down_write(&mm->mmap_sem);
atomic64_sub(npages, &mm->pinned_vm);
up_write(&mm->mmap_sem);
}
}

0 comments on commit 0e15c25

Please sign in to comment.